DylanDev•3w ago

Patching two values in a document causes functions to be re triggered

I have a function called checkGuess which checks the user's guess and returns data relating to their guess. Additionally, it updates a the "level" document in my levels table by adding 1 to times played and adding 1 to correctguesses if they got it right. However, when I add this patch code, it is triggering my original function again that pulls down 5 random levels and is causing the game to loop indefinitely?

export const checkGuess = mutation({
  args: { levelId: v.id("levels"), selectedImageId: v.id("images") },
  handler: async(ctx, args) => {
    const level = await ctx.db.get(args.levelId);

    if(!level) {
      throw new Error("No levels exist");
    }

    let AIGeneratedImageId;
    let AIGeneratedImagePrompt;

    for (const imageId of level.images) {
      const image = await ctx.db.get(imageId);
      if (image && image.isAIGenerated) {
        AIGeneratedImageId = image;
        AIGeneratedImagePrompt = image.AIGeneratedPrompt;
        break;
      }
    }

    if(!AIGeneratedImageId) {
      throw new Error("No AI-generated image found.");
    }

    let score = 0;
    let correct = false;

    if(args.selectedImageId === AIGeneratedImageId._id) {
      score = 50;
      correct = true;
    } else {
      score = 0;
      correct = false;
    }

    const totalPlays = level.totalPlays + 1n;
    const correctAnswers = correct ? (level.correctAnswers + 1n) : level.correctAnswers;
    const globalAccuracy = totalPlays > 0n ? ((correctAnswers * 100n) / totalPlays) : 0n;

    await ctx.db.patch(level._id, {
      totalPlays,
      correctAnswers
    });

    return {
      correct,
      correctImageId: AIGeneratedImageId._id,
      groupName: level.groupName,
      classification: level.classification,
      hints: level.hints,
      aiImagePrompt: AIGeneratedImagePrompt,
      score,
      globalAccuracy: globalAccuracy
    };
  }
});

export const checkGuess = mutation({
  args: { levelId: v.id("levels"), selectedImageId: v.id("images") },
  handler: async(ctx, args) => {
    const level = await ctx.db.get(args.levelId);

    if(!level) {
      throw new Error("No levels exist");
    }

    let AIGeneratedImageId;
    let AIGeneratedImagePrompt;

    for (const imageId of level.images) {
      const image = await ctx.db.get(imageId);
      if (image && image.isAIGenerated) {
        AIGeneratedImageId = image;
        AIGeneratedImagePrompt = image.AIGeneratedPrompt;
        break;
      }
    }

    if(!AIGeneratedImageId) {
      throw new Error("No AI-generated image found.");
    }

    let score = 0;
    let correct = false;

    if(args.selectedImageId === AIGeneratedImageId._id) {
      score = 50;
      correct = true;
    } else {
      score = 0;
      correct = false;
    }

    const totalPlays = level.totalPlays + 1n;
    const correctAnswers = correct ? (level.correctAnswers + 1n) : level.correctAnswers;
    const globalAccuracy = totalPlays > 0n ? ((correctAnswers * 100n) / totalPlays) : 0n;

    await ctx.db.patch(level._id, {
      totalPlays,
      correctAnswers
    });

    return {
      correct,
      correctImageId: AIGeneratedImageId._id,
      groupName: level.groupName,
      classification: level.classification,
      hints: level.hints,
      aiImagePrompt: AIGeneratedImagePrompt,
      score,
      globalAccuracy: globalAccuracy
    };
  }
});

11 Replies

DylanDevOP•3w ago

The left video is with the following code and the right video is without it. You can notice at the bottom of the in between levels page that the level number isn't updating either? Code causing issue:

await ctx.db.patch(level._id, {
  totalPlays,
  correctAnswers
});

await ctx.db.patch(level._id, {
  totalPlays,
  correctAnswers
});

Let me know if any of you have any idea why this could be happening I can share more code if you'd like to see how my game logic works but I have been scratching my head for the last 3 hours 😂

lee•3w ago

convex queries rerun when the data they read changes. so this makes sense. to fix, i would avoid calling Math.random from the query and instead pass in the random seed as an argument. That way, when the query reruns, it will pick the same levels again. alternatively, you could choose to just run the query once, not rerun it whenever the data changes. you can do this with const convex = useConvex() and then on page load (like in a useEffect) call const levels = await convex.query(...);

DylanDevOP•3w ago

oh smart. i was thinking of doing a seed so i could make a daily challenge based on the current date as the seed are you able to provide more info on the seed? Is this on the backend function or do I call this on the client when i call the function

jamwt•3w ago

my project does this: https://github.com/jamwt/fastest-roundest-pokemon

GitHub

GitHub - jamwt/fastest-roundest-pokemon: Making t3dotgg's roundest ...

Making t3dotgg's roundest pokemon app go fast. Contribute to jamwt/fastest-roundest-pokemon development by creating an account on GitHub.

jamwt•3w ago

convex function: https://github.com/jamwt/fastest-roundest-pokemon/blob/14c0087c08aa057d0231d72659877036a4b5de35/convex/pokemon.ts#L13

GitHub

fastest-roundest-pokemon/convex/pokemon.ts at 14c0087c08aa057d0231d...

Making t3dotgg's roundest pokemon app go fast. Contribute to jamwt/fastest-roundest-pokemon development by creating an account on GitHub.

jamwt•3w ago

call site: https://github.com/jamwt/fastest-roundest-pokemon/blob/14c0087c08aa057d0231d72659877036a4b5de35/app/routes/index.tsx#L11

GitHub

fastest-roundest-pokemon/app/routes/index.tsx at 14c0087c08aa057d02...

Making t3dotgg's roundest pokemon app go fast. Contribute to jamwt/fastest-roundest-pokemon development by creating an account on GitHub.

jamwt•3w ago

this is using tanstack-query, but it works just the same with regular convex useQuery

DylanDevOP•3w ago

Thank you jamie! I'll @ you if i have any questions 🙂

lee•3w ago

it looks like the pokemon example still uses Math.random in the query; it doesn't use the seed. i think this library works https://www.npmjs.com/package/rand-seed

npm

rand-seed

A small library for generating random numbers. Latest version: 2.1.7, last published: 7 months ago. Start using rand-seed in your project by running npm i rand-seed. There are 11 other projects in the npm registry using rand-seed.

lee•3w ago

here's an example of using it https://github.com/get-convex/aggregate/blob/41e443347dbe1c084f112da7311ffb402509e9da/example/convex/shuffle.ts#L84

GitHub

aggregate/example/convex/shuffle.ts at 41e443347dbe1c084f112da7311f...

Component for aggregating counts and sums of Convex documents - get-convex/aggregate

DylanDevOP•2w ago

Thank you @lee

Patching two values in a document causes functions to be re triggered

Did you find this page helpful?