Actions support for diamond dependencies
As of a deploy ~15 minutes ago, one of my actions (haven't tested others) is failing with odd errors such as
request for './GOVPJE23.js' is not yet fulfilled and Failed to evaluate module.
16 Replies
I recently (earlier today) upgraded from
0.10.0 to 0.12.1This looks wrong
I'm importing a type from
queries/internal/getProductOrderFulfillmentStatuses into actions/internal/sendMfals940, which is probably how this is coming up in the latter. Could that also be a problem (importing a type from a query file into an action file)?
I extracted the type from queries/internal/getProductOrderFulfillmentStatuses into its own file and re-deployed, but I'm getting the same error when running actions/internal/sendMfals940 and queries/internal/getProductOrderFulfillmentStatuses looks similarly obfuscated in the Convex web UI.hmm... internal functions are new, possibly related to that. maybe @sshader has some ideas?
@RJ Are these functions still working for you? Our source mapping logic is separate from (and more primitive than) our bundle and deploy logic, so want to confirm this is annoying but not bringing down your app
The
actions/internal/sendMfals940 function is not working for me
Thankfully that’s ok today, as the app isn’t “live” yet (but will be in a couple days)
(“Live” in the sense that no one is relying on it for anything, yet)@RJ could you try moving it up one level, so it's
actions/sendMfalse940 as a workaround for now?@ballingt do you mean move it up a level in the directory structure, or make it an
action vs an internalAction (which it indeed currently is)?
Tried both, and neither worked!
(Observing the same error as before)@RJ have you tried removing code from your action(s) (including imports) and then readding it to see what is breaking it? (would be good to check that an empty action or internalAction works)
I'll start experimenting, but was hoping you all would have some leads!
Sorry about this! If you're free after noon Eastern it'd be great to look together, I'll try for a repro first.
I should be free a little after that, I'll give you a ping then @ballingt
If you're still around I'm free any time henceforth @ballingt!
Btw your original code should work now. We have fixed the diamond dependency issue.
What was the issue? Is it resolved?
The issue was with certain module dependency graphs where the same dependency was imported via multiple paths. @RJ had a workaround where all actions were defined in each file and we have deployed a fix earlier today, that made his original code structure work. So
request for './<dependency>.js' is not yet fulfilled should not happen anymore.Great, thanks @Presley! I'm not going to test this right now as I don't want to take the time to refactor this back to the way it was at the moment, but next week I will.
Reverted to original code structure and seeing no problems now. Thanks @Presley!